Skip to content
This repository has been archived by the owner on May 27, 2019. It is now read-only.

Browser extensions in Webstore are out of date #117

Closed
tanderson92 opened this issue Aug 11, 2017 · 8 comments
Closed

Browser extensions in Webstore are out of date #117

tanderson92 opened this issue Aug 11, 2017 · 8 comments
Assignees

Comments

@tanderson92
Copy link

The browserpass page shows the latest version as 1.0.5.: https://chrome.google.com/webstore/detail/browserpass/jegbgfamcgeocbfeebacnkociplhmfbk

But the latest version is 1.0.6.

@maximbaz maximbaz changed the title The Google Chrome browserpass is out of date Browser extensions in Webstore are out of date Sep 15, 2017
@maximbaz
Copy link
Member

maximbaz commented Sep 15, 2017

Same goes for Firefox - we cannot do this without @dannyvankooten.


Repeating #83 (comment) for visibility:

I really wish I could update the packages myself, but I have neither .pem file to sign the packages nor access to webstore to actually update them. Only @dannyvankooten has these, so only he can push updates to webstore.

Subscribe to this issue and you will get notification when webstore is updated.

I guess if there will be no answer from Danny for a while, we'll have to publish the packages to the webstore under a different name.

maximbaz added a commit that referenced this issue Sep 16, 2017
…nsion

Chrome policy simplifies installation for people, but until I find a way
to update extension in Webstore it does more harm than good.

related: #134, #117
@maximbaz
Copy link
Member

v2.0.0 was just released in Chrome and Firefox webstores!

These are the new extensions, rebranded as Browserpass - Community Edition, so you have to remove the old ones if you still have them installed.

Enjoy 🙂

@chrboe
Copy link
Contributor

chrboe commented Sep 29, 2017

This is the most satisfying thing, seeing all of these issues being resolved 🙂 Thanks for the release Maxim!

(As a side note, we should probably still take care to maintain backwards compatibility with the old extension, since a lot of people will still be using that)

@maximbaz
Copy link
Member

I made the host app incompatible with the old extension, and I did it on purpose, as there is no excuse not to upgrade frontend if one is upgrading the host app to v2 😛

It is a one-time action anyway, future updates will be pushed via Webstore automatically. Furthermore, we have the chrome-policy.json back, meaning that Chrome extension is installed automatically from the store (no luck for Firefox... and for Windows users, for now - #163)

@chrboe
Copy link
Contributor

chrboe commented Sep 29, 2017

I don't know, I just don't like the idea of it silently failing because of an upgrade (many people won't even be aware of the new extension name).

I assume it just fails with Error talking to browserpass host now, right? My concern is primarily that people will be filing hard-to-debug errors caused by the upgrade that just say "it doesn't work". Though I guess we could figure it out if they manage to report their versions correctly 🤔

I guess there's not much we can do about it anyways, it's not like we can change the old extension (to display an appropriate error) 🤷‍♂️.

Speaking of errors: I know this is getting off topic, but how about reporting more verbose errors to the UI in general? 🙂

Just thought about this a little more, and I guess there actually aren't any errors that can happen except "something is wrong with the host binary" 🤔 So nevermind the verbose errors thing, unless we can maybe get more error details from the browser?

@maximbaz
Copy link
Member

I think it is worth the risk, it's a temporary inconvenience that has lots of long-term benefits for everyone. But the concern is valid, and I hope it will be at least partially handled by this ticket with catchy title that I'll leave open for a couple of weeks: #165.

Speaking of errors handling, let's discuss it separately - in #164.

@tanderson92
Copy link
Author

Thank you very much Maxim! The new shortcut behavior seems acceptable too.

The "Find more username fields" feature is welcome and seems to improve some sites. Thanks! Unfortunately it's still broken on citi.com, which is only a very minor inconvenience.

@maximbaz
Copy link
Member

@tanderson92 I fixed the citi.com support in 4cf2dae - will be a part of 2.0.1 release 😉

Note for everyone: do not hesitate opening new issues for sites where browserpass doesn't fill passwords in, sometimes we cannot do anything about it, but sometimes it is really useful, investigating citi.com actually brought up two major improvements to the detection algorithm, which will improve other websites too (details in the commit message for those of you who are interested).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants