Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for working with transforms #357

Merged
merged 2 commits into from Apr 5, 2018
Merged

Support for working with transforms #357

merged 2 commits into from Apr 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 4, 2018

Informing Watchify about files to watch.

Informing Watchify about files to watch.
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, great! Thanks for getting on that so quickly :)

Left two comments about spelling and markdown syntax, let me know if it's unclear!

readme.markdown Outdated
If your custom transform for browserify adds new files to bundle in a non-standard way without requiring.
You can inform Watchify about these files by emiting 'file' event.

module.exports = function(file) {
Copy link
Member

@goto-bus-stop goto-bus-stop Apr 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surround this with a fenced code block to make it syntax highlight correctly:

```js
code here
```

readme.markdown Outdated
# working with browserify transforms

If your custom transform for browserify adds new files to bundle in a non-standard way without requiring.
You can inform Watchify about these files by emiting 'file' event.
Copy link
Member

@goto-bus-stop goto-bus-stop Apr 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small spelling improvements:

  • to bundle → to the bundle
  • emiting 'file' event → emitting a 'file' event

@ghost
Copy link
Author

ghost commented Apr 4, 2018

Done :)

@ghost
Copy link
Author

ghost commented Apr 5, 2018

How to merge it?

Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed your update. thanks!

@goto-bus-stop goto-bus-stop merged commit d232754 into browserify:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant