Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version option #197

Closed
wants to merge 1 commit into from
Closed

Add version option #197

wants to merge 1 commit into from

Conversation

caspervonb
Copy link
Contributor

No description provided.

@zertosh
Copy link
Member

zertosh commented Apr 9, 2015

Nah, npm ls watchify already gives you the version.

browserify's CLI already uses v and version. So we'd be breaking parity, and we can't use v because that's already for verbose.

Frankly the value of this option is not worth the trouble.

@zertosh
Copy link
Member

zertosh commented Apr 19, 2015

Once browserify/browserify#1222 goes through, we can do this PR without the "V". Also to make it a bit more useful, how about something like?

if (w.argv.version) {
    console.log(
        'watchify v%s (in %s)',
        require('../package.json').version,
        path.dirname(require.resolve('../package.json'))
    )
    console.log(
        'browserify v%s (in %s)',
        require('browserify/package.json').version,
        path.dirname(require.resolve('browserify/package.json'))
    )
    process.exit(0);
}

@zertosh zertosh mentioned this pull request Apr 19, 2015
4 tasks
@caspervonb
Copy link
Contributor Author

Nah, npm ls watchify already gives you the version.

Granted npm ls watchify does give you the version but that is not necessarily the same as what is in being invoked in the shell through watchify, and when asking for the watchify version someone is running they're not likely to check npm.

Once browserify/browserify#1222 goes through, we can do this PR without the "V". Also to make it a bit more useful ...

👍

@zertosh
Copy link
Member

zertosh commented Apr 26, 2015

I made the changes on your commit f667e99

@zertosh zertosh closed this Apr 26, 2015
@zertosh
Copy link
Member

zertosh commented Apr 26, 2015

Thanks! sorry for the long wait on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants