Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inheritance is botched #25

Open
pkit opened this issue Apr 8, 2020 · 0 comments
Open

inheritance is botched #25

pkit opened this issue Apr 8, 2020 · 0 comments
Labels

Comments

@pkit
Copy link

pkit commented Apr 8, 2020

const sb = require('stream-browserify')
const rb = new sb.Readable()
console.log(rb instanceof sb.Stream) // false

const s = require('stream')
const r = new s.Readable()
console.log(r instanceof s.Stream) // true

it's coming from readable-stream inheriting from the stream instead of stream-browserify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants