check if process.version is available #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have the same problem with Nativescript... |
dalinarkholin
approved these changes
May 6, 2020
11 tasks
guimard
added a commit
to guimard/pbkdf2
that referenced
this pull request
Jan 19, 2022
guimard
added a commit
to guimard/pbkdf2
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use the Hapi Joi module in Nativescript for validations, because it's a cool validation module.
And Joi drags in pbkdf2, but the native app isn't running in Node so there is no process.version variable, and it causes the app to crash.
This minor code change just adds a check to see if process.version is defined and if it's not, it defaults the encoding to UTF-8, similar to the browser scenario, thus keeping Joi from crashing.
Shouldn't make any difference in a Node environment....but sure helps otherwise! ;-)
Thanks!