Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #43 #67

Closed
wants to merge 2 commits into from
Closed

Fix #43 #67

wants to merge 2 commits into from

Conversation

salemkode
Copy link

No description provided.

@salemkode salemkode mentioned this pull request Dec 27, 2021
Closed
ljharb
ljharb requested changes Dec 27, 2021
View reviewed changes
util.js Outdated

if (process.env.NODE_DEBUG) {
var debugEnv = process.env.NODE_DEBUG;
if (process && process.env && process.env.NODE_DEBUG) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will still error if process isn't defined.

and, it is always defined, since this is a node module.

util.js
if (process.env.NODE_DEBUG) {
var debugEnv = process.env.NODE_DEBUG;
if (process && process.env && process.env.NODE_DEBUG) {
var debugEnv = env.NODE_DEBUG;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is broken; env isn't a global variable.

@ljharb ljharb marked this pull request as draft December 27, 2021 18:20
@salemkode salemkode marked this pull request as ready for review December 28, 2021 03:26
@salemkode
Copy link
Author

image
Now it is work

@ljharb
Copy link
Member

ljharb commented Dec 28, 2021

env.NODE_DEBUG is still broken, it needs to be process.env.NODE_DEBUG.

@ljharb
Copy link
Member

ljharb commented Mar 27, 2022

Closing, because process is always defined in a node module (in node, or when bundled by a non-broken node module bundler).

@ljharb ljharb closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salemkode @ljharb