Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not apply root transforms on linked modules #99

Merged
1 commit merged into from
Oct 16, 2015

Conversation

chrisirhc
Copy link
Contributor

resolver now accepts a 4th argument which should be the original
(non-real) file path.

Required for fixing browserify/browserify#1386 / browserify/browserify#1365

Definitely could use a better variable name, so this is open for suggestion and comments.

This change is missing tests right now. I'll add them if I get some feedback that we might want to merge this.

resolver now accepts a 4th argument which should be the original
(non-real) file path.
@ghost
Copy link

ghost commented Oct 16, 2015

Thanks! I've published this as 4.0.0 to be extra cautious since in previous releases symlink issues have been very sensitive. I think we can put this into the browserify v12 release.

@chrisirhc
Copy link
Contributor Author

Sounds good to me. I didn't add tests, but I can look into adding them later. Wasn't sure if this solution was of interest.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant