Updated to ESLint #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
ljharb
requested changes
Nov 15, 2023
| @@ -43,7 +43,7 @@ | |||
| "@ljharb/eslint-config": "^21.1.0", | |||
| "aud": "^2.0.3", | |||
| "auto-changelog": "^2.4.0", | |||
| "eslint": "=8.8.0", | |||
| "eslint": "^8.8.0", | |||
There was a problem hiding this comment.
this makes the peer dep invalid; 8.8.0 is the last version that properly parses ES3 code with the strict pragma.
There was a problem hiding this comment.
yes I understand the issue now .
Thankyou for the response I will try to improve upon my shortcomings.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -1,6 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| var crypto = require('crypto'); | |||
| const crypto = require('crypto'); | |||
There was a problem hiding this comment.
this is a breaking change for pre-const engines.
There was a problem hiding this comment.
Yeah an oversight on my part.
Thanks for the response.
Abeanna
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the ESLint package and also made some minor adjustments to index.js file.
Thank you.