Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the paths option, doesn't lookup anymore on node_modules #41

Closed
slorber opened this issue May 16, 2014 · 4 comments
Closed

Using the paths option, doesn't lookup anymore on node_modules #41

slorber opened this issue May 16, 2014 · 4 comments

Comments

@slorber
Copy link

slorber commented May 16, 2014

The doc says:

paths - require.paths array to use if nothing is found on the normal node_modules recursive walk

Actually, I have a configuration where the following works:

    return browserify({
            entries: ['./src/js/app.js'],
            extensions: ['.jsx'],
            paths: ['./node_modules','./src/js/home']
        })

While the following doesn't:

    return browserify({
            entries: ['./src/js/app.js'],
            extensions: ['.jsx'],
            paths: ['./src/js/home']
        })

So, I guess when using the paths option, the code doesn't try anymore to lookup into the node modules, while the doc says it should

@defunctzombie
Copy link
Collaborator

Please create a failing example against this module. Looks like your
example is using browserify, unless that is just bad naming of variables.
On May 16, 2014 9:38 AM, "Sébastien Lorber" [email protected]
wrote:

The doc says:

paths - require.paths array to use if nothing is found on the normal node_modules recursive walk

Actually, I have a configuration where the following works:

return browserify({
        entries: ['./src/js/app.js'],
        extensions: ['.jsx'],
        paths: ['./node_modules','./src/js/home']
    })

While the following doesn't:

return browserify({
        entries: ['./src/js/app.js'],
        extensions: ['.jsx'],
        paths: ['./src/js/home']
    })

So, I guess when using the paths option, the code doesn't try anymore to
lookup into the node modules, while the doc says it should


Reply to this email directly or view it on GitHubhttps://github.com//issues/41
.

@slorber
Copy link
Author

slorber commented May 16, 2014

@defunctzombie sure I'll show you soon. I'm building a starter kit for Gulp / Browserify / React / Less / Phonegap actually and will open source it in some hours

@TooTallNate
Copy link
Contributor

Actually I believe that my PR in #43 fixes this.

@slorber
Copy link
Author

slorber commented Jun 11, 2014

cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants