Minor HTML fixes #197
Open
Minor HTML fixes #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes invalid HTML.
Previously, spaces were used almost everywhere.
|
Hey Zaz, thanks for checking this out. I will take a look at these soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit makes some minor HTML fixes to the home page.
<div>s after<li>s are not valid HTML, so I replaced them with<p>s inside<li>s. So now the HTML for sheets matches the structure of the HTML for publications. That led to the second commit, which removes thespreadsheet-related-content,publication-link, andpublicationsclasses:Note that the second commit messes up the formatting slightly on your home 500 page, but I'm not sure what is going on with that file; it seems it is possibly out of date. You also may be able to use
home.handlebarsto handle both the 400 and 500 cases. I'll leave it to you to decide how to handle that.The third commit replaces all tabs with spaces. Previously, spaces were used almost everywhere.
This is untested.