Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features and bug fixing #33

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Features and bug fixing #33

merged 2 commits into from
Feb 28, 2023

Conversation

kmilo9999
Copy link
Collaborator

@kmilo9999 kmilo9999 commented Feb 27, 2023

Features

  • Convert multiple nc variables to volumes:
    This new version receives a list of variables to read from the nc model file.
    It adds the logic in the resulting desc file to read multiple volumes in the volume-viewer

Fixes:

  • Texture labels flipped horizontally
  • Volume viewer data converter was saving the incorrect extension for 2D texture mapped volumes.

Copy link
Member

@gtdang gtdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

volume_data_converter/create_volume_viewer_data.py Outdated Show resolved Hide resolved
volume_data_converter/create_volume_viewer_data.py Outdated Show resolved Hide resolved
Copy link
Member

@gtdang gtdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kmilo9999 kmilo9999 merged commit 7f1af46 into main Feb 28, 2023
@kmilo9999 kmilo9999 deleted the feature-multiple-variables branch February 28, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants