Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix <Experiment /> layout when JsPsych is running the experiment #261

Merged
merged 9 commits into from
Sep 1, 2023

Conversation

RobertGemmaJr
Copy link
Member

  • Removes unnecessary layout effects
  • Renames <JsPsychExperiment /> as <Experiment />
  • Adds then for handling the end of jsPsych running

@RobertGemmaJr RobertGemmaJr self-assigned this Aug 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Visit the preview URL for this PR (updated for commit 239fc52):

https://ccv-honeycomb--pr261-fix-layout-effect-ed0g2uuz.web.app

(expires Fri, 08 Sep 2023 14:18:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

@RobertGemmaJr RobertGemmaJr changed the base branch from main to v4 August 10, 2023 18:54
@RobertGemmaJr RobertGemmaJr changed the base branch from v4 to ref-home-online August 10, 2023 18:55
@RobertGemmaJr RobertGemmaJr linked an issue Aug 21, 2023 that may be closed by this pull request
Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is quite a bit of commented out code in thie PR, should that stay commented out or removed?

Base automatically changed from ref-home-online to v4 September 1, 2023 14:08
@RobertGemmaJr
Copy link
Member Author

There is quite a bit of commented out code in thie PR, should that stay commented out or removed?

The stuff inside src/jspsych/timeline is okay, yes. I've been testing a bunch of different trials at different times so that's why they're all there

@RobertGemmaJr RobertGemmaJr merged commit 68e3f7e into v4 Sep 1, 2023
8 checks passed
@RobertGemmaJr RobertGemmaJr deleted the fix-layout-effect branch September 1, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use useLayoutEffect in JsPsychExperiment
2 participants