Initialize footer #20
Conversation
|
Visit the preview URL for this PR (updated for commit dc8e504): https://ccv-website-next--pr20-footer-4ew5pfi2.web.app (expires Wed, 13 Nov 2024 21:29:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 809aa2d3a6cfe026c3c7417c932015a8f1d9ec89 |
| <div className="mt-8 grid grid-cols-1 lg:grid-cols-5 gap-8 xl:col-span-2"> | ||
| {Object.entries(navigation).map(([_, contents]) => { | ||
| return ( | ||
| <div key={_}> |
There was a problem hiding this comment.
I personally don't love using the _ here, it's a little nitpicky, but if you're going to use the value I think you should either change the _ to key or something or use the href for the key value. So it could look like either of these:
<div key={key> ...<div key={href}> ...
| @@ -9,7 +13,7 @@ const LogoBrown: React.FC = () => { | |||
| xmlns="http://www.w3.org/2000/svg" | |||
| x="0px" | |||
| y="0px" | |||
| width="100%" | |||
| width={width} | |||
| 1fr | ||
| min(1000px, 100%) | ||
| 1fr; | ||
| @apply bg-white; |
There was a problem hiding this comment.
what happened to the styles that got removed here? that's intentional?
| </div> | ||
| </div> | ||
|
|
||
| <div className="mt-8 grid grid-cols-1 lg:grid-cols-5 gap-8 xl:col-span-2"> |
There was a problem hiding this comment.
hmm i was checking this out on the preview and maybe we should have a md style here too? like maybe md:grid-cols-3 or something? it's a little awkward in the sm to lg transition period i think
No description provided.