Skip to content

Commit

Permalink
added geometry option
Browse files Browse the repository at this point in the history
  • Loading branch information
brosaplanella committed May 26, 2020
1 parent 1007c87 commit fda5342
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion pybamm/models/full_battery_models/base_battery_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ def options(self, extra_options):
"current collector": "uniform",
"particle": "Fickian diffusion",
"thermal": "isothermal",
"geometry": "arbitrary",
"external submodels": [],
"sei": None,
}
Expand Down Expand Up @@ -273,6 +274,10 @@ def options(self, extra_options):
raise pybamm.OptionError(
"Unknown thermal model '{}'".format(options["thermal"])
)
if options["geometry"] not in ["arbitrary", "pouch"]:
raise pybamm.OptionError(
"Unknown geometry '{}'".format(options["geometry"])
)
if options["sei"] not in [
None,
"constant",
Expand Down Expand Up @@ -548,7 +553,7 @@ def set_thermal_submodel(self):

elif self.options["thermal"] == "lumped":
thermal_submodel = pybamm.thermal.Lumped(
self.param, self.options["dimensionality"]
self.param, self.options["dimensionality"], self.options["geometry"]
)

elif self.options["thermal"] == "x-lumped":
Expand Down

0 comments on commit fda5342

Please sign in to comment.