pybamm-team#718 added tests for li-ion lumped

brosaplanella · May 26, 2020 · 71d0b51 · 71d0b51
1 parent 91e0bac
commit 71d0b51
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/...integration/test_models/test_full_battery_models/test_lithium_ion/test_compare_outputs.py b/...integration/test_models/test_full_battery_models/test_lithium_ion/test_compare_outputs.py
@@ -55,6 +55,8 @@ def test_compare_outputs_thermal(self):
         # load models - for the default params we expect x-full and lumped to
         # agree as the temperature is practically independent of x
         options = [{"thermal": opt} for opt in ["lumped", "x-full"]]
+        options.append({"thermal": "lumped", "geometry": "pouch"})
+
         model_combos = [
             ([pybamm.lithium_ion.SPM(opt) for opt in options]),
             ([pybamm.lithium_ion.SPMe(opt) for opt in options]),

diff --git a/tests/unit/test_models/test_submodels/test_thermal/test_lumped.py b/tests/unit/test_models/test_submodels/test_thermal/test_lumped.py
@@ -27,6 +27,18 @@ def test_public_functions(self):
         std_tests = tests.StandardSubModelTests(submodel, coupled_variables)
         std_tests.test_all()
 
+        submodel = pybamm.thermal.Lumped(param, cc_dimension=0, geometry="pouch")
+        std_tests = tests.StandardSubModelTests(submodel, coupled_variables)
+        std_tests.test_all()
+
+        submodel = pybamm.thermal.Lumped(param, cc_dimension=1, geometry="pouch")
+        std_tests = tests.StandardSubModelTests(submodel, coupled_variables)
+        std_tests.test_all()
+
+        submodel = pybamm.thermal.Lumped(param, cc_dimension=2, geometry="pouch")
+        std_tests = tests.StandardSubModelTests(submodel, coupled_variables)
+        std_tests.test_all()        
+
 
 if __name__ == "__main__":
     print("Add -v for more debug output")