Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Rack::Response::Helpers in responses #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scttnlsn
Copy link

@scttnlsn scttnlsn commented May 2, 2016

This includes Rack::Response::Helpers methods in the Airborne responses. This enables the use of matchers like those commonly used with ActionDispatch::TestResponse.

i.e.


expect(response).to be_success
expect(response).to be_redirect
expect(response).to be_error
# etc.

A few other notes:

  • I added a rest_client_options setting (currently being used to set max_redirects)
  • I had to change the way that the requester module is accessed in base.rb. I was encountering an issue in the specs where once Airborne.configuration.rack_app was set it impacted other specs (that expected this value to be nil). I believe this issue is not showing itself on master since rack_sinatra_spec.rb is loaded last.

@coveralls
Copy link

coveralls commented May 2, 2016

Coverage Status

Coverage increased (+0.05%) to 99.019% when pulling 731802f on scttnlsn:rack-helpers into 3cc4112 on brooklynDev:master.

@coveralls
Copy link

coveralls commented May 2, 2016

Coverage Status

Coverage increased (+0.05%) to 99.019% when pulling 1eb107d on scttnlsn:rack-helpers into 3cc4112 on brooklynDev:master.

@scttnlsn
Copy link
Author

Fixed the merge conflicts here. Any interest in this PR?

@coveralls
Copy link

coveralls commented Aug 31, 2016

Coverage Status

Coverage increased (+0.05%) to 99.023% when pulling a55c7a2 on scttnlsn:rack-helpers into 55311ac on brooklynDev:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants