Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade runtime dependencies #149

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

mycargus
Copy link
Contributor

Relying on TravisCI to run the tests here. I tried running them but all I got was this error:

Netrc::Error:
         Permission bits for '/Users/mhargiss/.netrc' should be 0600, but are 644

I don't want to grant those permissions. :)

@coveralls
Copy link

coveralls commented Mar 21, 2019

Coverage Status

Coverage increased (+0.1%) to 99.21% when pulling a948c5e on mycargus:upgrade-runtime-dependencies into 9175995 on brooklynDev:master.

@mycargus
Copy link
Contributor Author

Ah, going to have to modify the supported Ruby runtimes too:

There are no versions of rubygems-update (= 3.0.3) compatible with your Ruby & RubyGems
	rubygems-update requires Ruby version >= 2.3.0. The current ruby version is 2.2.0.

New commit incoming...

@sethpollack
Copy link
Collaborator

hmm, are we dropping support for those versions of ruby?

@mycargus
Copy link
Contributor Author

mycargus commented Mar 21, 2019

Oh, happy to change it to maintain existing Ruby version support! I was thinking to support the latest of each Ruby minor version, but I'm game for whatever. I think the only exception will have to be 2.2 given rubygems-update requires >= 2.3.0

Copy link
Collaborator

@sethpollack sethpollack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@sethpollack sethpollack merged commit d65b099 into brooklynDev:master Mar 21, 2019
@mycargus mycargus deleted the upgrade-runtime-dependencies branch March 21, 2019 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants