Serialize to JSON when content type is set to JSON #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, the request body is only serialized if it's a Hash. But it could be an Array, or any other serializable type, and those bodies are serialized. See brooklynDev#129, probably brooklynDev#141 as well. I am not sure if this wouldn't break use cases where the body is already expected to be serialized.
|
Might need to update the README as well. |
|
Not sure the README addition is clear & simple enough, but that's more explicit that way at least. |
|
This is great! I encountered the same issue recently while using airborne. @sethpollack +1 from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the request body is only serialized if it's a Hash.
But it could be an Array, or any other serializable type and those bodies are serialized.
See #129, probably #141 as well.
I am not sure if this wouldn't break use cases where the body is already expected to be serialized.