Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.6.0 updates part 1 #32

Merged
merged 31 commits into from
Jul 16, 2019
Merged

0.6.0 updates part 1 #32

merged 31 commits into from
Jul 16, 2019

Conversation

brodycj
Copy link
Owner

@brodycj brodycj commented Jul 16, 2019

based on DRAFT PR #30:

  • changes from @timojaask fork, with some additional cleanup & documentation (resolves Updates from @timojaask fork #22)
  • update-notifier@3 update in package dependencies
  • new exampleReactNativeVersion option
  • some other updates & fixes

TODO items not included in this PR:

timojaask and others added 30 commits May 8, 2019 15:30
@timojaask
Add example project name parameter
b8506d1
@timojaask
WIP
3d4200f
@timojaask
Fix setting example project name
9186f26
@timojaask
Fix .npmignore template to support custom example name
70cac8e
@timojaask
Pass exampleName to example template
caac2b3
@timojaask
Pass exampleName to comments in example template
d510ee0
@timojaask
Set podspec name to module name for conventions
3c738ae
@timojaask
Add AFNetworking pod to library as an example
658be86
@timojaask
Add description, which is inherited and required by podspec
4c12ca1
@timojaask
Add ios example podfile
69e2ffa
@timojaask
Add AFNetworking test code
727a2be
@timojaask
Add use cocoapods flag
1700472
@timojaask
Fix formatting
8d4f516
@timojaask
Fix Podfile generator but where module was hardcoded
f0947e7
@timojaask
Make TestLibrary.xcworkspace compilable on its own
1acf3e7
@timojaask
Revert "Fix Podfile generator but where module was hardcoded"
06020fa 
This reverts commit f0947e7.
@timojaask
Remove the Podfile from library ios project, because it messes up exa…
07e76dd 
…mple build
@timojaask
Fix hardcoded target name in example Podfile
a12cbe8
Quick lint fixes to templates/ios.js
128798b
Other lint fixes
e936f6f
eslint updates in devDependencies
abc2d05
Bump version to 0.6.0-dev
0363059
update-notifier@3 update
467b0ef
Cleanup & fix generateExampleWithName in lib.js
06622af 
- remove ignored react-native init options
- factor const execCommand string into its own line
- add react-native init command info to logging
@timojaask
Update doc for exampleName & useCocoapods options
71e8724 
Co-authored-by: Christopher J. Brody <[email protected]>
Co-authored-by: Timo Jääskeläinen <[email protected]>
Completely remove npm fallback for example
64272c2
Updated TODO comments in generated code
1345354 
for iOS & Android

(with one TODO comment restored for iOS)
factor duplicated keys out of command.js
a6007f9
Fix some more fields in generated podspec
b150523
Add exampleReactNativeVersion option
27ff5f3 
defaults to [email protected] for now

(use exampleReactNativeVersion="react-native@latest" to generate
 example with the most current react-native release)
@brodycj brodycj merged commit 81f8109 into dev Jul 16, 2019
@brodycj brodycj deleted the 0.6.0-part-1 branch July 16, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updates from @timojaask fork
2 participants
@brodycj @timojaask