Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exists-sync. Add relative path test. #82

Merged
merged 2 commits into from
Nov 4, 2016
Merged

Update exists-sync. Add relative path test. #82

merged 2 commits into from
Nov 4, 2016

Conversation

nathanhammond
Copy link
Contributor

Closes #81. Stemming from the adoption of exists-sync.

Will track upstream fix at ember-cli/exists-sync#4.

@nathanhammond
Copy link
Contributor Author

nathanhammond commented Nov 4, 2016

  1. fs.existsSync has been un-deprecated making this an acceptable solution.
  2. Upstream issue addressed as a bugfix for portions of the community who may still use that module.

@trabus
Copy link

trabus commented Nov 4, 2016

I would be careful switching back, we added some additional checking for symlinks that link to symlinks. fs.existsSync will (or at least used to) give a false positive on a symlink that links to another symlink who's target has been removed.

If we can verify that fs.existsSync recursively follows symlinks until it hits something rather than giving a false positive, I’m fine switching. But if not, we’d hit some issues that we had previously run into.

@nathanhammond
Copy link
Contributor Author

Now that upstream is fixed I'll rework this.

@nathanhammond nathanhammond changed the title Remove exists-sync temporarily. Add relative path test. Update exists-sync. Add relative path test. Nov 4, 2016
@stefanpenner stefanpenner merged commit 4736c45 into broccolijs:master Nov 4, 2016
@stefanpenner
Copy link
Contributor

@nathanhammond nathanhammond deleted the exists-sync-relpath branch November 4, 2016 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception is thrown in 1.0.8 with relative paths in broccoli-funnel
5 participants