Ensure adding additional trees does not affect include/exclude results. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a7ed4fa we added support for passing additional trees to the constructor (to ensure that they can be ready to read in subclasses), but we didn't ensure that all internal usage of `this.input` was limited to the first tree passed. This didn't matter much for the simple symlink srcDir <-> destDir situation, but as soon as you use custom `include`/`exclude` globs (and we therefore have to walk all the files) we would trigger errors. This fixes that oversight by ensuring that all usage of `this.input` is scoped to `this.input.at(0)`, and adds a previously failing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a7ed4fa we added support for passing additional trees to the constructor (to ensure that they can be ready to read in subclasses), but we didn't ensure that all internal usage of
this.inputwas limited to the first tree passed. This didn't matter much for the simple symlink srcDir <-> destDir situation, but as soon as you use custominclude/excludeglobs (and we therefore have to walk all the files) we would trigger errors.This fixes that oversight by ensuring that all usage of
this.inputis scoped tothis.input.at(0), and adds a previously failing test.