Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop gathering instantiation stack manually. #141

Merged
merged 1 commit into from
May 26, 2021

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented May 26, 2021

This was added waaaaaay back in 46e1e23 (2014), long before the newer broccoli-plugin APIs (around Broccoli@1) started creating an instantiation stack to be used for error handling across the board.

Now that we extend from broccoli-plugin directly, we no longer have to do this manually. Additionally, the code in broccoli-plugin is authored such that it avoids touching the .stack property unless it is actually needed (forcing V8 to create the stack is costly).

Thanks to @krisselden for pointing this out.

This was added waaaaaay back in 46e1e23 (2014), long before the newer
`broccoli-plugin` APIs (around Broccoli@1) started creating an
instantiation stack to be used for error handling across the board.

Now that we extend from broccoli-plugin directly, we no longer have to
do this manually. Additionally, the code in broccoli-plugin is authored
such that it avoids touching the `.stack` property unless it is actually
needed (forcing V8 to create the stack is costly).
@rwjblue rwjblue added the bug label May 26, 2021
@rwjblue rwjblue merged commit f5a6a80 into master May 26, 2021
@rwjblue rwjblue deleted the remove-redundant-stacks branch May 26, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant