Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nhash_id to multiome, optimus, paired-tag, and atac #1316

Merged
merged 18 commits into from
Jul 11, 2024

Conversation

ekiernan
Copy link
Contributor

@ekiernan ekiernan commented Jul 1, 2024

Description

Adding NHash ID as input to BICAN workflows

This PR add optional nhash_id to Optimus, ATAC, Multiome, and Paired-tag workflows. It outputs the nhash_id to the h5ads in the adata.uns section and the gene expression library-level metrics (first line). It also names the library metrics CSV using the nhash_id.

Copy link

github-actions bot commented Jul 1, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 1, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
atac.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 1, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 1, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 1, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
atac.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 1, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 3, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 3, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 3, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not had its version updated
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 3, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 3, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not had its version updated
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 3, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

@ekiernan ekiernan closed this Jul 8, 2024
@ekiernan ekiernan reopened this Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Remember to squash merge!

1 similar comment
Copy link

github-actions bot commented Jul 8, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 8, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

1 similar comment
Copy link

github-actions bot commented Jul 8, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 8, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not had its version updated
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

1 similar comment
Copy link

github-actions bot commented Jul 8, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not had its version updated
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 8, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 8, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 8, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not had its version updated
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 8, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 8, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
Optimus.wdl has not had its version updated
MultiSampleSmartSeq2SingleNucleus.wdl has not been changed and needs updating
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not had its version updated
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jul 8, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Optimus.changelog.md has not been changed and needs to be updated
MultiSampleSmartSeq2SingleNucleus.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
PairedTag.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

@ekiernan ekiernan closed this Jul 9, 2024
@ekiernan ekiernan reopened this Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 9, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

github-actions bot commented Jul 9, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

github-actions bot commented Jul 9, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 9, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

github-actions bot commented Jul 9, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

github-actions bot commented Jul 9, 2024

Remember to squash merge!

Copy link

github-actions bot commented Jul 9, 2024

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

github-actions bot commented Jul 9, 2024

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link
Contributor

@kevinpalis kevinpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekiernan
Copy link
Contributor Author

retest this please

1 similar comment
@ekiernan
Copy link
Contributor Author

retest this please

@ekiernan ekiernan merged commit e52f2c1 into develop Jul 11, 2024
12 checks passed
@ekiernan ekiernan deleted the lk-PD-2690-NHashID branch July 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants