increase default instance memory for kraken2 task 72 -> 90GB #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increase instance memory for kraken2 task 72->90GB to support use of the JHU standard PlusPF db
dpark01
approved these changes
May 20, 2024
There was a problem hiding this comment.
Looks good. Let's merge. Some thoughts for the future:
- maybe at some point in the future we should change it to some function of
size(kraken2_db_tgz)but I'd rather not do that here quite yet.. maybe wait for Terra support of WDL 1.1 which would allow us to say things likemin(16, 1.8 * size(kraken2_db_tgz) + 1)as an example - When messing with the runtime block of some of these tasks it's worth double checking empirically that the file localization speed benefits from the 2024-era improvements in Terra. This runtime block doesn't have some of the cpu platform hints but I think the other aspects of the VM shape force it into the right place where, based on Lydia's runs last weekend, it does look like it's localizing all of the inputs (including PlusPF) in about 1 minute, which is great.
kraken2 task: specify runtime CPU hint; cpuPlatform: "Intel Ice Lake"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address OOM failures running kraken2 with the JHU standard PlusPF database, this PR increases the default amount of memory requested for the instance used for the kraken2 task, from 72 to 90GB.