Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task for terra backend env exploration #495

Closed
wants to merge 4 commits into from

Conversation

tomkinsc
Copy link
Member

No description provided.

Copy link
Member

@dpark01 dpark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, this isn't actually a PR against master, you're just playing in a branch to grab some reconnaissance / telemetry from Terra, but can the PR be closed?

description: "Command that can optionally be included and executed as part of this task"
}
}
command {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
command {
command <<<

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need to switch syntax?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we standardizing toward <<< to discourage WDL interpolation of${}?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there's definitely a number of bashisms that simply won't work with the older WDL syntax

@tomkinsc tomkinsc marked this pull request as draft October 20, 2023 17:43
@tomkinsc
Copy link
Member Author

Yeah, this is all for inspection and not intended to be merged (unless we want to preserve some ability to inspect the environment?)

@dpark01
Copy link
Member

dpark01 commented Oct 20, 2023

Ok, recommend closing this PR, as it's not necessary for the build, CI testing, or Terra testing

@tomkinsc tomkinsc closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants