feat!: [BITSDN-3201] dogfood shared-workflows #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbenezriravin
force-pushed
the
lihu/BITSDN-3201
branch
3 times, most recently
from
a9ddd45
to
f2304c1
Compare
|
I like a lot of these changes. I made some changes while you were out, so this will have to be rebased, etc. I added a bunch of documentation to the README, so the names in there will have to be lined up with the new names you used for all the workflows. |
lbenezriravin
force-pushed
the
lihu/BITSDN-3201
branch
from
f2304c1
to
c56541f
Compare
Checking out the repository is not necessary for the conventional-commits checker action, as evidenced by this repo's own workflow. Reading the code, it reaches out directly to github. Reading the code, the code is also *terrible*. Clunky, inflexible, hacked-together, and barely maintained. I'd like to get off this third-party dependency ASAP.
Commented-out code should not be committed to main, as it undermines the whole purpose of using version control.
lbenezriravin
force-pushed
the
lihu/BITSDN-3201
branch
from
c56541f
to
957deb9
Compare
lbenezriravin
force-pushed
the
lihu/BITSDN-3201
branch
2 times, most recently
from
c64ccf0
to
14dbb87
Compare
lbenezriravin
force-pushed
the
lihu/BITSDN-3201
branch
from
14dbb87
to
9cf9e85
Compare
lbenezriravin
force-pushed
the
lihu/BITSDN-3201
branch
6 times, most recently
from
426056f
to
e715234
Compare
Rename the workflows to more consistently reflect what they do. More importantly, namespace them because github reusable workflows must all be in the same top-level directory. * If a workflow simply vendorizes a third-party tool with certain values/boilerplate hardcoded, it is named the same as the tool. * Otherwise, the naming scheme is `<namespace>-[test-]<verb>`. "test-" is pulled out to the front both to distinguish it from unit tests and as an obvious marker that this workflow should probably be refactored.
Reading the plaintext docs is difficult with long lines. I'd like to remove the line length exception from the default markdownling config, but that's not in scope for this PR. Also, single space after a period is the recommendation from nearly all major style guides.
Pull the existing action out of local-checks to its own workflow for re-use/expansion later.
lbenezriravin
force-pushed
the
lihu/BITSDN-3201
branch
from
e715234
to
f11d6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BITSDN-3201