Fix deprecated uses of newInstance() #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droazen
approved these changes
Jun 2, 2023
| final CommandLineProgram program; | ||
| try { | ||
| program = (CommandLineProgram) Class.forName(programClassname).getDeclaredConstructor().newInstance(); | ||
| } catch (InvocationTargetException | NoSuchMethodException e) { |
There was a problem hiding this comment.
catch (IllegalAccessException | InstantiationException | NoSuchMethodException | InvocationTargetException e)
There was a problem hiding this comment.
I replaced that with catch (ReflectiveOperationException e) and removed a bunch of boilerplate.
lbergelson
commented
Jun 2, 2023
| @@ -267,7 +274,7 @@ static void assertCRAM(final File outputFile) { | |||
| try (InputStream in = new FileInputStream(outputFile)) { | |||
| Assert.assertTrue(SamStreams.isCRAMFile(new BufferedInputStream(in)), "File " + outputFile.getAbsolutePath() + " is not a CRAM."); | |||
| } catch (IOException e) { | |||
| e.printStackTrace(); | |||
| throw new RuntimeIOException(e); | |||
There was a problem hiding this comment.
I also changed this from a silent success to an exception since it seems like it could easily hide errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace instances of
newInstance()which is deprecated withgetDeclaredConstructor().newInstance()which is the drop in replacement.