Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to CompareMetrics #1839

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Conversation

kachulis
Copy link
Contributor

Adds the following additional features to CompareMetrics:

  1. Command line parameter METRICS_NOT_REQUIRED to specify metrics which may be missing from either input.
  2. Command line parameter KEY to specify a metric column to use as a key for metrics comparisons. This is useful for checking if the only difference between two metrics files is the order of the rows.
  3. Option to output a tsv table of metrics differences. This is much easier to evaluate than the current text output.

@kachulis kachulis requested a review from meganshand October 28, 2022 20:37
Copy link
Contributor

@meganshand meganshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@nikellepetrillo nikellepetrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

@kachulis kachulis merged commit b65515c into master Nov 2, 2022
@kachulis kachulis deleted the ck_compare_metrics_additions branch November 2, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants