Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the EXT argument to CollectSamErrorMetrics. #1478

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Add the EXT argument to CollectSamErrorMetrics. #1478

merged 4 commits into from
Feb 6, 2024

Conversation

nh13
Copy link
Collaborator

@nh13 nh13 commented Feb 28, 2020

Description

So that we can have the nice ".txt" file extension on output files.

Checklist (never delete this)

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

@yfarjoun yfarjoun added the Waiting For Revisions This PR has received comments from reviewers and is waiting for the Author to respond label Apr 3, 2020
@kockan kockan requested a review from yfarjoun June 27, 2023 17:30
@kockan kockan requested a review from lbergelson August 10, 2023 16:52
lbergelson
lbergelson approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems totally reasonable.

@lbergelson lbergelson merged commit 48545af into master Feb 6, 2024
@lbergelson lbergelson deleted the nh_collect_sam_error_metrics_extension branch February 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kockan kockan kockan left review comments

@lbergelson lbergelson lbergelson approved these changes

@yfarjoun yfarjoun Awaiting requested review from yfarjoun

Assignees
No one assigned
Labels
Waiting For Revisions This PR has received comments from reviewers and is waiting for the Author to respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nh13 @yfarjoun @lbergelson @kockan