Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the VCF option in CollectSamErrorMetrics optional. #1476

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

nh13
Copy link
Collaborator

@nh13 nh13 commented Feb 28, 2020

Description

In many cases, were re-sequencing a sample that does not differ from the reference genome (ex. E. Coli). I would like to run CollectSamErrorMetrics without having to give an empty VCF.

Funnily enough, this was internally supported, but the VCF option was never set to be optional. Just see the initializeVcfDataSource method to verify.

Checklist

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@nh13 nh13 force-pushed the nh_collect_sam_error_metrics_no_vcf branch from 9d2ed2f to 89c0122 Compare February 28, 2020 23:08
Copy link
Member

@pshapiro4broad pshapiro4broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these minor formatting issues, looks good otherwise.

@pshapiro4broad pshapiro4broad added the Waiting For Revisions This PR has received comments from reviewers and is waiting for the Author to respond label May 27, 2020
@kockan kockan requested a review from pshapiro4broad June 15, 2023 15:57
@kockan kockan requested a review from kachulis June 27, 2023 17:24
@kockan kockan requested a review from lbergelson August 10, 2023 16:53
@kockan kockan merged commit 6f2c61a into master Feb 15, 2024
6 checks passed
@kockan kockan deleted the nh_collect_sam_error_metrics_no_vcf branch February 15, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting For Revisions This PR has received comments from reviewers and is waiting for the Author to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants