[JN-1020] Fix Enrollee view when Outreach has undefined task/response #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MatthewBemis
changed the title
MatthewBemis
commented
May 31, 2024
| </NavLink> | ||
| {badgeForResponses(responseMap[stableId].response)} | ||
| {createSurveyNavLink(stableId, responseMap, survey)} | ||
| {badgeForResponses(responseMap[stableId]?.response)} |
There was a problem hiding this comment.
this line is the crux of the change
connorlbark
approved these changes
May 31, 2024
devonbush
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
Noticed this while debugging the survey/task completion issue. The enrollee view wouldn't render correctly if the study had an outreach survey and the selected enrollee hadn't recorded a "response" for it yet. Also slightly refactors how the survey/task links are generated to prevent "undefined" from being in the URL if the participant hadn't been assigned that particular task.
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)