[JN-1533] Consistent env var access (#1323)

broadinstitute · Dec 10, 2024 · 18a1595 · 18a1595
1 parent 5680da0
commit 18a1595
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/core/src/main/java/bio/terra/pearl/core/service/logging/MixpanelService.java b/core/src/main/java/bio/terra/pearl/core/service/logging/MixpanelService.java
@@ -69,13 +69,14 @@ public void logEvent(String data) {
     }
 
     protected JSONObject buildEvent(JSONObject event) {
-        MessageBuilder messageBuilder = new MessageBuilder(env.getProperty("mixpanel.token"));
+        String MIXPANEL_TOKEN_ENV_VAR = "env.mixpanel.token";
+        MessageBuilder messageBuilder = new MessageBuilder(env.getProperty(MIXPANEL_TOKEN_ENV_VAR));
 
         return messageBuilder.event(
                 null,
                 event.getString("event"),
                 event.getJSONObject("properties")
-                        .put("token", env.getProperty("mixpanel.token"))
+                        .put("token", env.getProperty(MIXPANEL_TOKEN_ENV_VAR))
         );
     }
 

diff --git a/core/src/test/java/bio/terra/pearl/core/service/logging/MixpanelServiceTests.java b/core/src/test/java/bio/terra/pearl/core/service/logging/MixpanelServiceTests.java
@@ -23,7 +23,7 @@ public void testBuildEvent() {
         event.put("properties", properties);
 
         env = mock(Environment.class);
-        when(env.getProperty("mixpanel.token")).thenReturn("test-token");
+        when(env.getProperty("env.mixpanel.token")).thenReturn("test-token");
         MixpanelService mockedMixpanelService = new MixpanelService(env);
 
         JSONObject result = mockedMixpanelService.buildEvent(event);