Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating upload_artifact in github actions #9061

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Updating upload_artifact in github actions #9061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/upload-gatk-test-results/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ runs:
steps:
- name: Upload test results
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
# ternary expression syntax is workaround found here https://github.com/actions/runner/issues/409
name: test-results-${{ inputs.is-docker == 'true' && 'docker-' || '' }}${{ matrix.Java }}-${{ matrix.testType }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gatk-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
outputs: type=docker,dest=/tmp/myimage.tar
# By uploading the docker image as an artifact we save ourselves the requirement for the image to be built with ghcr push permission
- name: Upload docker image as artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: gatkDockerImage
path: /tmp/myimage.tar
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
cp scripts/docker/dockertest.gradle .

- name: Download docker image artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: gatkDockerImage
path: /tmp
Expand Down
Loading