Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle and build.gradle #8998

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Update gradle and build.gradle #8998

merged 8 commits into from
Oct 18, 2024

Conversation

lbergelson
Copy link
Member

  • update gradle wrapper 8.2.1 -> 8.10.2
  • remove 'versions' plugin because we don't use it
  • update gradle plugins to new versions
    • shadow plugin changed maintainers and coordinates com.github.johnrengelman.shadow:8.1.1 -> com.gradleup.shadow:8.3.3
    • git-version 0.5.1 -> 3.1.0
    • sonatype scan 2.6.1 -> 2.8.3
    • download 5.4.0 -> 5.6.0
  • use tasks.register() which is the newer style

@gatk-bot
Copy link

gatk-bot commented Oct 14, 2024

Github actions tests reported job failures from actions build 11334895424
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 17.0.6+10 11334895424.10 logs
unit 17.0.6+10 11334895424.12 logs
integration 17.0.6+10 11334895424.11 logs

@lbergelson lbergelson marked this pull request as ready for review October 15, 2024 20:24
@lbergelson lbergelson assigned lbergelson and unassigned lbergelson Oct 15, 2024
@lbergelson
Copy link
Member Author

@droazen @KevinCLydon If one of you wants to take a look at this that would be great. It updates a bunch of build and housekeeping stuff. It doesn't resolve all the dependency vulnerabilities yet.

* update gradle wrapper 8.2.1 ->  8.10.2
* remove 'versions' plugin because we don't use it
* update gradle plugins to new versions
  * shadow plugin changed maintainers and coordinates
	com.github.johnrengelman.shadow:8.1.1 -> com.gradleup.shadow:8.3.3
  * git-version 0.5.1 -> 3.1.0
  * sonatype scan 2.6.1 -> 2.8.3
  * download 5.4.0 -> 5.6.0
* use tasks.register() which is the newer style

# Conflicts:
#	build.gradle
* update several dependencies that have known vulnerabilities
* replace deprecated override of ThresholdStream.getStream() -> getOutputStream()
Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing objectionable here

@@ -80,13 +80,10 @@ do
esac
done

APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit

APP_NAME="Gradle"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it not need to specify appname anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogenerated. I just roll with whatever they suggest.

@lbergelson lbergelson merged commit df8e4b7 into master Oct 18, 2024
20 checks passed
@lbergelson lbergelson deleted the lb_gradle_updates branch October 18, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants