-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle and build.gradle #8998
Conversation
lbergelson
commented
Oct 11, 2024
- update gradle wrapper 8.2.1 -> 8.10.2
- remove 'versions' plugin because we don't use it
- update gradle plugins to new versions
- shadow plugin changed maintainers and coordinates com.github.johnrengelman.shadow:8.1.1 -> com.gradleup.shadow:8.3.3
- git-version 0.5.1 -> 3.1.0
- sonatype scan 2.6.1 -> 2.8.3
- download 5.4.0 -> 5.6.0
- use tasks.register() which is the newer style
Github actions tests reported job failures from actions build 11334895424
|
42f8118
to
2d85c3d
Compare
@droazen @KevinCLydon If one of you wants to take a look at this that would be great. It updates a bunch of build and housekeeping stuff. It doesn't resolve all the dependency vulnerabilities yet. |
* update gradle wrapper 8.2.1 -> 8.10.2 * remove 'versions' plugin because we don't use it * update gradle plugins to new versions * shadow plugin changed maintainers and coordinates com.github.johnrengelman.shadow:8.1.1 -> com.gradleup.shadow:8.3.3 * git-version 0.5.1 -> 3.1.0 * sonatype scan 2.6.1 -> 2.8.3 * download 5.4.0 -> 5.6.0 * use tasks.register() which is the newer style # Conflicts: # build.gradle
* update several dependencies that have known vulnerabilities * replace deprecated override of ThresholdStream.getStream() -> getOutputStream()
2d85c3d
to
48747d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing objectionable here
@@ -80,13 +80,10 @@ do | |||
esac | |||
done | |||
|
|||
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit | |||
|
|||
APP_NAME="Gradle" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it not need to specify appname anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is autogenerated. I just roll with whatever they suggest.