Inverted SoftClippedReadFilter to conform to filtering logic #8888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesemery
force-pushed
the
je_patchSoftclippedReadFilterLogic
branch
from
985ba41 to
853c008
Compare
droazen
approved these changes
Jun 27, 2024
| @@ -53,8 +53,8 @@ private ReadFilterArgumentDefinitions(){} | |||
|
|
|||
| public static final String KEEP_INTERVAL_NAME = "keep-intervals"; | |||
|
|
|||
| public static final String SOFT_CLIPPED_RATIO_THRESHOLD = "soft-clipped-ratio-threshold"; | |||
| public static final String SOFT_CLIPPED_LEADING_TRAILING_RATIO_THRESHOLD = "soft-clipped-leading-trailing-ratio"; | |||
| public static final String SOFT_CLIPPED_RATIO_THRESHOLD = "max-soft-clipped-ratio-threshold"; | |||
There was a problem hiding this comment.
Maybe this should be called just max-soft-clipped-ratio, for better consistency with max-soft-clipped-leading-trailing-ratio (while we're changing argument names....)
There was a problem hiding this comment.
good point. Done
|
Github actions tests reported job failures from actions build 9702596193
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like when this was added, a mistake was made between a filter returning test() == true (passing the filter) and test() == false (failing the filter, read removed). Furthermore the invert filter argument in here is now redundant as of #8724 and I will go ahead and remove it from this filter. I have also tweaked the filter arguments slightly to clarify what they do now mean more intuitively.
Fixes #8887