-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to include list of popular software included in docker image #8745
Conversation
scripts/docker/gatkbase/Dockerfile
Outdated
@@ -1,5 +1,6 @@ | |||
# Using OpenJDK 17 | |||
# This Dockerfile does not require any files that are in the GATK4 repo. | |||
# NOTE: If you updated the ubtuntu version make sure to update the samtools/bcftools/bedtools versions in the README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubtuntu -> ubuntu
Why are the genomics tools versions dependent on ubuntu version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a similar note about updating the README in the conda template yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a while since I've used Ubuntu desktop but thought that certain versions set upper limits on the apt repo versions, so some packages latest versions won't work on older Ubuntu releases... is that right? If not then I'm not sure where the comment could go. The apt commands install whatever latest is available at the time, so it's possible if they aren't pinned to the distro version then they could change underneath us without realizing with a new build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like something like this is happening (and versions might've already changed under us without realizing!). I made a simple ubuntu docker from 20.04 and then from 24.04 and installed samtools
using the exact same updating commands from our Dockerfile. The earlier version installed 1.10 and the latter installed 1.19.2. So I think the apt repos are somehow pinned to the ubuntu version, but it's not clear if those could still update with the same ubuntu point release.
As the title suggests, this PR includes a quick update to our README to include documentation on what tools are included in our docker images.