Clarify cryptic bitwise operations in Partiall-determined haplotype EventGroup subclass #8400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesemery
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
👍 A few documentation requests and exactly one material comment that if the bitset object is going to be limited to 30 elements you should put more guardrails into the thing (unless you want to make it a private class) to protect against having to find out what an overflow does here...
I trust you can address those comments and merge without me blocking you again on this.
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Show resolved
Hide resolved
rickymagner
pushed a commit
that referenced
this pull request
Nov 28, 2023
…ventGroup subclass (#8400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jamesemery Another DRAGEN PR for you. No change in output, but it lays some of the groundwork for having multiple determined events at one locus and will make addition of more features easier.
It runs just as fast as before -- the bit-twiddling is encapsulated, but it's still there.