-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variants GATK Docker image building docs + script [VS-827] #8207
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8207 +/- ##
================================================
Coverage ? 84.116%
Complexity ? 34488
================================================
Files ? 2194
Lines ? 167012
Branches ? 18001
================================================
Hits ? 140484
Misses ? 20093
Partials ? 6435 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see nothing flagrantly wrong, but should I be running this? Should we do a round on mobbing?
apt-get install --assume-yes docker-ce docker-ce-cli containerd.io docker-buildx-plugin docker-compose-plugin | ||
|
||
# Make sure this all worked with a Docker 'Hello World!' test. | ||
docker run hello-world |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your confidence concerns me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@RoriCremer I think it would be OK to merge this as-is and then if somebody actually needs to make a GATK jar and discovers issues with these instructions to make a follow-up ticket + PR |
No description provided.