Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escapes for otherwise problematic BigQuery dataset / table names. #8162

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Jan 13, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@fedb320). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8162   +/-   ##
================================================
  Coverage                ?   86.243%           
  Complexity              ?     35202           
================================================
  Files                   ?      2173           
  Lines                   ?    165045           
  Branches                ?     17793           
================================================
  Hits                    ?    142340           
  Misses                  ?     16380           
  Partials                ?      6325           

Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also, good that you updated the standard script block preamble here

@mcovarr mcovarr merged commit 8a7b95d into ah_var_store Jan 13, 2023
@mcovarr mcovarr deleted the add_bq_escapes branch January 13, 2023 21:49
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants