-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to not prepare __REF_DATA table to Prepare [VS-697] #8079
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8079 +/- ##
================================================
Coverage ? 86.191%
Complexity ? 35200
================================================
Files ? 2173
Lines ? 165041
Branches ? 17794
================================================
Hits ? 142251
Misses ? 16460
Partials ? 6330 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would note that GvsCallsetStatistics no longer needs the __SAMPLE table created here. So, it too could be made optional (although it's not that expensive to make it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the thorough testing.
Since we might need to run the GvsPrepareRangesCallset.wdl in the future just to help to get the callset stats, add an optional input to not create the __REF_DATA and __SAMPLES tables, since those won't be needed.
Test runs:
skip_ref_ranges_tables
set totrue
:skip_ref_ranges_tables
set tofalse
skip_ref_ranges_tables
not set (default is false)... after changes ...
only_output_vet_tables
set totrue
only_output_vet_tables
set tofalse