Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not prepare __REF_DATA table to Prepare [VS-697] #8079

Merged
merged 13 commits into from
Nov 7, 2022

Conversation

rsasch
Copy link

@rsasch rsasch commented Oct 28, 2022

Since we might need to run the GvsPrepareRangesCallset.wdl in the future just to help to get the callset stats, add an optional input to not create the __REF_DATA and __SAMPLES tables, since those won't be needed.

Test runs:

@rsasch rsasch marked this pull request as ready for review October 28, 2022 20:21
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@18fa298). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8079   +/-   ##
================================================
  Coverage                ?   86.191%           
  Complexity              ?     35200           
================================================
  Files                   ?      2173           
  Lines                   ?    165041           
  Branches                ?     17794           
================================================
  Hits                    ?    142251           
  Misses                  ?     16460           
  Partials                ?      6330           

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! 👍

Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbggrant gbggrant self-requested a review October 31, 2022 16:01
Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would note that GvsCallsetStatistics no longer needs the __SAMPLE table created here. So, it too could be made optional (although it's not that expensive to make it).

Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the thorough testing.

@rsasch rsasch merged commit 7dd6ede into ah_var_store Nov 7, 2022
@rsasch rsasch deleted the rsa_vs_697 branch November 7, 2022 21:06
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants