Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-698 Remove unnecessary columns from Call set statistics #8073

Merged
merged 6 commits into from
Oct 26, 2022

Conversation

gbggrant
Copy link
Collaborator

Lee has given us a list of columns that are no longer needed in the call set statistics file. This PR removes them.

@gbggrant
Copy link
Collaborator Author

Example here: https://app.terra.bio/#workspaces/allofus-drc-wgs-dev/GVS%20AoU%20WGS%2010K%20Callset/job_history/e7fc2972-31b9-4db0-bc8d-de5efa778a9d
Note that I took the output file from this workflow and compared it with a callset statistics file generated from the 'normal' run. When I cut out the columns from that statistics file that had been dropped in this PR, it matched perfectly.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@116db44). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8073   +/-   ##
================================================
  Coverage                ?   44.264%           
  Complexity              ?     24497           
================================================
  Files                   ?      2173           
  Lines                   ?    165041           
  Branches                ?     17793           
================================================
  Hits                    ?     73053           
  Misses                  ?     86738           
  Partials                ?      5250           

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too

@gbggrant gbggrant merged commit e6d736b into ah_var_store Oct 26, 2022
@gbggrant gbggrant deleted the gg_VS-698_OnlyNeededColumnsInCallsetStats branch October 26, 2022 20:37
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants