Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the path reported by the gatkbot when there are test failures #8069

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

lbergelson
Copy link
Member

@jamesemery please review

@lbergelson lbergelson requested a review from jamesemery October 21, 2022 19:49
@lbergelson lbergelson marked this pull request as ready for review October 21, 2022 19:49
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #8069 (dee692a) into master (9321181) will increase coverage by 34.097%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##              master     #8069        +/-   ##
================================================
+ Coverage     52.542%   86.639%   +34.097%     
- Complexity     29595     38933      +9338     
================================================
  Files           2334      2334                
  Lines         182619    182619                
  Branches       20048     20047         -1     
================================================
+ Hits           95952    158219     +62267     
+ Misses         80602     17362     -63240     
- Partials        6065      7038       +973     
Impacted Files Coverage Δ
...roadinstitute/hellbender/tools/LocalAssembler.java 67.425% <0.000%> (+0.073%) ⬆️
...roadinstitute/hellbender/utils/read/ReadUtils.java 82.278% <0.000%> (+0.316%) ⬆️
...stitute/hellbender/cmdline/CommandLineProgram.java 84.516% <0.000%> (+0.645%) ⬆️
...lyBasedSVDiscoveryTestDataProviderForSimpleSV.java 100.000% <0.000%> (+0.894%) ⬆️
.../main/java/org/broadinstitute/hellbender/Main.java 72.685% <0.000%> (+1.389%) ⬆️
...llbender/engine/filters/SoftClippedReadFilter.java 94.286% <0.000%> (+2.857%) ⬆️
...VDiscoveryTestDataProviderForBreakEndVariants.java 100.000% <0.000%> (+3.279%) ⬆️
...org/broadinstitute/hellbender/utils/RandomDNA.java 96.629% <0.000%> (+4.494%) ⬆️
...coveryTestDataProviderForInversionBreakpoints.java 100.000% <0.000%> (+4.615%) ⬆️
...bender/utils/pairhmm/FlowBasedPairHMMUnitTest.java 8.108% <0.000%> (+5.405%) ⬆️
... and 585 more

Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbergelson, thanks for fixing this annoying bug! Just verified it on a failed PR.

@droazen droazen merged commit 4e17418 into master Nov 7, 2022
@droazen droazen deleted the lb_fix_test_report_path branch November 7, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants