Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to the pileup arguments #8050

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

yfarjoun
Copy link
Contributor

  • Added minValue and maxValue to the pileup arguments
  • fixed documentation for pileup arguments to avoid using "percentage"

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #8050 (a234002) into master (633aa4a) will increase coverage by 0.001%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##              master     #8050       +/-   ##
===============================================
+ Coverage     86.641%   86.642%   +0.001%     
+ Complexity     38962     38959        -3     
===============================================
  Files           2336      2336               
  Lines         182731    182731               
  Branches       20066     20067        +1     
===============================================
+ Hits          158320    158321        +1     
- Misses         17367     17368        +1     
+ Partials        7044      7042        -2     
Impacted Files Coverage Δ
...otypecaller/PileupDetectionArgumentCollection.java 100.000% <ø> (ø)
...nder/utils/runtime/StreamingProcessController.java 66.818% <0.000%> (-0.455%) ⬇️
...itute/hellbender/tools/LocalAssemblerUnitTest.java 92.448% <0.000%> (ø)
.../hellbender/utils/python/PythonUnitTestRunner.java 78.689% <0.000%> (+3.279%) ⬆️

Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yfarjoun. I should have been more careful in defining these arguments in the first place...

- fixed documentation for pileup arguments to avoid using "percentage"
@lbergelson lbergelson force-pushed the yf_fix_pileup_arguments branch from 314dc65 to a234002 Compare December 23, 2022 20:25
@lbergelson lbergelson self-assigned this Dec 23, 2022
@lbergelson
Copy link
Member

I'm forcing this to rerun tests so we can merge it.

@lbergelson lbergelson merged commit 16fc4f1 into master Dec 23, 2022
@lbergelson lbergelson deleted the yf_fix_pileup_arguments branch December 23, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants