Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to GVS Integration WDL [VS-618] #8042

Merged
merged 5 commits into from
Sep 29, 2022

Conversation

rsasch
Copy link

@rsasch rsasch commented Sep 28, 2022

  • go back to drop_state of "FORTY"
  • add sort to table size check SQL to make sure the order is deterministic
  • use alpine SDK docker
  • turn off xtrace on already chatty bash

successful run here: https://job-manager.dsde-prod.broadinstitute.org/jobs/7b8e1506-771d-425f-b545-6e0411b6f7c0

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@9994658). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8042   +/-   ##
================================================
  Coverage                ?   86.249%           
  Complexity              ?     35200           
================================================
  Files                   ?      2173           
  Lines                   ?    165004           
  Branches                ?     17792           
================================================
  Hits                    ?    142314           
  Misses                  ?     16362           
  Partials                ?      6328           

@@ -119,7 +119,6 @@ task AssertIdenticalOutputs {
set -o errexit
set -o nounset
set -o pipefail
set -o xtrace
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😿

I'd be sad to see these xtraces wiped out as they have saved my bacon many times. Happy to discuss this at (post) standup tomorrow.

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in standup I'll make a ticket to investigate a less obtrusive way of capturing this xtrace info.

@rsasch rsasch merged commit 0735df7 into ah_var_store Sep 29, 2022
@rsasch rsasch deleted the rsa_vs_618_integration branch September 29, 2022 17:11
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants