-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the Dataflow Mark Duplicates by running the existing Mark Duplicates tests on the Dataflow code. #798
Conversation
output = new File(outputDir, "output.sam"); | ||
addArg("--INPUT", input.getAbsolutePath()); | ||
addArg("--OUTPUT", output.getAbsolutePath()); | ||
if (useStandardInputNames) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that we have to have this switch here. Could you open a ticket to update tools so that it is unnecessary? Subtask of #133
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just made it. #805.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Seemed like the least invasive way for now, but it's definitely a hack.
@tovanadler Review complete. Lets only disable the tests for dataflow. Thanks for including the test failure reason in there. |
Thanks for the review. Back at you Louis. |
👍 Looks good. Squash these down to a single commit and you're ready to merge. |
a591549
to
82699ce
Compare
@jean-philippe-martin can you take over? If this done? (it seems to so) |
@akiezun I think you're asking me to squash/merge this code. Is this right? |
yes, thanks. rebase+squash and merge |
…tests that don't pass yet, and we will revisit them to figure out where the bug is.
82699ce
to
7f87eaa
Compare
rebase+squash. Merge pending green tests. |
Add tests for the Dataflow Mark Duplicates by running the existing Mark Duplicates tests on the Dataflow code.
No description provided.