-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cost WDL should throw on FISS API errors [VS-518] #7942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mcovarr
commented
Jul 13, 2022
•
edited
Loading
edited
rsasch
approved these changes
Jul 13, 2022
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7942 +/- ##
================================================
Coverage ? 86.240%
Complexity ? 35197
================================================
Files ? 2173
Lines ? 165003
Branches ? 17793
================================================
Hits ? 142298
Misses ? 16378
Partials ? 6327 |
mcovarr
force-pushed
the
vs_518_throw_on_fiss_api_error
branch
from
July 13, 2022 18:18
1ae3cc2
to
da6f043
Compare
mcovarr
commented
Jul 13, 2022
@@ -59,16 +58,15 @@ task WorkflowComputeCosts { | |||
--workspace_namespace '~{workspace_namespace}' \ | |||
--workspace_name '~{workspace_name}' \ | |||
~{sep=' ' excluded_ids} \ | |||
> costs_by_workflow.json 2> workflow_compute_costs.log | |||
> costs_by_workflow.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let errors go to stderr where users can more easily see them in the job logs
RoriCremer
approved these changes
Jul 14, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.