-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test to validate WDLs in the scripts directory. #7826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gbggrant One comment on naming, otherwise looks good to merge once thats addressed. Thanks for doing this.
.github/workflows/gatk-tests.yml
Outdated
#test wdl validation | ||
wdlValidation: | ||
runs-on: ubuntu-latest | ||
name: Validate WDLs using womtools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you modify the names (workflow names, name property, gradle task names, and comments) so the "scripts" and "generated" versions are more clearly distinguished from each other (i.e., validteScriptsWDL
and validateGeneratedWDL
or something similar). Its hard to tell from looking at just this definition that it's not doing the autogenerated validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with Chris's suggestions
91af7ec
to
97ff6fd
Compare
Codecov Report
@@ Coverage Diff @@
## master #7826 +/- ##
===============================================
- Coverage 86.955% 86.953% -0.002%
+ Complexity 36903 36902 -1
===============================================
Files 2214 2214
Lines 173540 173540
Branches 18735 18735
===============================================
- Hits 150902 150899 -3
- Misses 16036 16039 +3
Partials 6602 6602
|
Renamed existing test for validating generated WDLs.
97ff6fd
to
db7b43f
Compare
Renamed existing test for validating generated WDLs.
No description provided.