Disable the red "X" from failing codeCov builds and delay the posting of coverage information to complete test. #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7817 +/- ##
===============================================
+ Coverage 86.941% 86.942% +0.001%
- Complexity 36860 36866 +6
===============================================
Files 2211 2211
Lines 173376 173376
Branches 18710 18709 -1
===============================================
+ Hits 150734 150736 +2
+ Misses 16055 16052 -3
- Partials 6587 6588 +1
|
lbergelson
reviewed
Apr 26, 2022
|
|
||
|
|
||
| comment: | ||
| layout: "header, diff, changes, sunburst, uncovered, tree" | ||
| branches: null | ||
| behavior: default | ||
| after_n_builds: 8 # Wait until all 8 of the test suite jacoco test builds have been uploaded before writing a comment to the pr (no more incomplete coverage report emails) |
There was a problem hiding this comment.
https://docs.codecov.com/docs/codecovyml-reference#codecovnotifywait_for_ci is another option that isn't tied to the build specifics
There was a problem hiding this comment.
@lbergelson I'm testing it over in #7818. If it works there I'll pull that commit into this branch and merge.
There was a problem hiding this comment.
Louis i've tried a few modes of that option. It doesn't seem to work so far as i can tell. There is probably something I misunderstand. I'm going to merge this approach since it does work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repost of #7815 to test the "after_n_builds" functionality