-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GvsUnified WDL to wrap the 6 core GVS WDLs [VS-382] #7789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
# Begin GvsPrepareRangesCallset | ||
String extract_table_prefix | ||
|
||
String query_project = project_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate with that on line 56.
And why is this even needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I'm surprised WDL allows completely duplicate declarations like that 😦
The query
and destination
versions of project and dataset are used in GvsPrepareCallset
and GvsExtractCallset
, though I do not know circumstances under which they would be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are used with GvsExtractCohortFromSampleNames.wdl where the GVS dataset and the delivered/billed datasets might be different.
String extract_table_prefix | ||
|
||
String query_project = project_id | ||
String destination_project = project_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is destination_project needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are used with GvsExtractCohortFromSampleNames.wdl where the GVS dataset and the delivered/billed datasets might be different.
a4c56ae
to
0c43bf2
Compare
0c43bf2
to
0e5a946
Compare
688b59c
to
675fa62
Compare
tl;dr This isn't the full ask for VS-357 but being able to run the Quickstart by launching 1 WDL instead 6 may represent a useful increment of work.