GetPileupSummaries streams output rather than storing it in memory #7664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbenjamin
requested review from
takutosato
and removed request for
lbergelson
|
@takutosato Would you mind reviewing this PR? |
takutosato
approved these changes
Mar 28, 2022
src/main/java/org/broadinstitute/hellbender/tools/walkers/contamination/GetPileupSummaries.java
Show resolved
Hide resolved
|
Thank-you, this will be super helpful! |
|
@davidbenjamin looks like a GATK release hasn't gone out since April, and this would be super helpful to my clients. Any thoughts on the next release date? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7606.
@lbergelson This addresses the excessive memory issue that you triaged recently. Would you mind reviewing it?